Re: Quoting of *_command arguments

On Wed, Nov 12, 2025 at 02:45:16PM +0100, Peter Eisentraut wrote:
> On 11.11.25 20:31, Bruce Momjian wrote:
> > We inconsistently double-quote the "%f" and "%p" arguments of
> > "archive_command" and "restore_command". Paths with spaces or special
> > characters, especially directory names in these cases, would need
> > double-quotes.
> >
> > This patch adds double-quotes to all instances. I can also go the other
> > way and remove them all, but we should be consistent.
>
> I think %f doesn't need to be quoted because it will only contain certain
> characters, but if we tried to clarify that it would probably be too
> confusing. It makes sense to nudge people that some quoting is prudent.

Yeah, I did consider your point but you are right --- it is too complex
to quote one and not the other and expect people to understand why.

> Your patch looks good to me.

Thanks.

--
Bruce Momjian <bruce(at)momjian(dot)us> https://momjian.us
EDB https://enterprisedb.com

Do not let urgent matters crowd out time for investment in the future.