| From: | Nathan Bossart <nathandbossart(at)gmail(dot)com> |
|---|---|
| To: | pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: obsolete autovacuum comment |
| Date: | 2025-11-11 20:35:28 |
| Message-ID: | aROeEHesJii30TJU@nathan |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, Nov 10, 2025 at 02:03:27PM -0600, Nathan Bossart wrote:
> While working on my autovacuum scheduling patch [0], I noticed the
> following comment in relation_needs_vacanalyze():
>
> /*
> * Note that we don't need to take special consideration for stat
> * reset, because if that happens, the last vacuum and analyze counts
> * will be reset too.
> */
>
> AFAICT this is a relic from pg_autovacuum (the contrib module and
> predecessor to modern autovacuum) [1] and early versions of the autovacuum
> patch [2] [3]. After digging through the archives [4], I think this is
> referring to some stats that had to be managed separately but weren't ever
> actually committed.
Patch attached.
> Any objections to removing this comment?
If none materialize, I will proceed with removal in a couple of days.
--
nathan
| Attachment | Content-Type | Size |
|---|---|---|
| v1-0001-remove-obsolete-autovacuum-comment.patch | text/plain | 1.1 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | David Rowley | 2025-11-11 20:43:46 | Re: another autovacuum scheduling thread |
| Previous Message | Dagfinn Ilmari Mannsåker | 2025-11-11 20:27:20 | Re: Improve tab completion for various SET/RESET forms |