Re: Add tests for object size limits of injection points

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com>
Cc: Postgres hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Add tests for object size limits of injection points
Date: 2025-11-10 03:31:50
Message-ID: aRFcpvQCkDF5a3H7@paquier.xyz
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Mon, Nov 10, 2025 at 10:30:31AM +0800, Chao Li wrote:
> Is really confused. The error message says “maximum of 64”, but the
> test right uses a name of length 64. I know that the tricky is the
> ‘\0’ terminator, but should SQL writer have to keep mind about the
> ‘\0’ terminator? Should they just consider maximum length as 63?

Right. We could add a "- 1" to the error message printed.
--
Michael

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Philip Warner 2025-11-10 03:43:33 Re: pg_dump not dumping default_text_search_config WAI?
Previous Message Xuneng Zhou 2025-11-10 03:22:20 Re: Optimize SnapBuildPurgeOlderTxn: use in-place compaction instead of temporary array