Re: Remove useless casts to (void *)

From: Bertrand Drouvot <bertranddrouvot(dot)pg(at)gmail(dot)com>
To: Álvaro Herrera <alvherre(at)kurilemu(dot)de>
Cc: Aleksander Alekseev <aleksander(at)tigerdata(dot)com>, pgsql-hackers(at)lists(dot)postgresql(dot)org, Peter Eisentraut <peter(at)eisentraut(dot)org>
Subject: Re: Remove useless casts to (void *)
Date: 2025-11-20 17:13:15
Message-ID: aR9MK4M8U3ipC+CJ@ip-10-97-1-34.eu-west-3.compute.internal
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi,

On Thu, Nov 20, 2025 at 04:43:58PM +0100, Álvaro Herrera wrote:
> On 2025-Nov-20, Aleksander Alekseev wrote:
>
> > IMO what actually is important is for the code to be consistent.
>
> IMO what is most important is that the code is correct. Second most
> important is that the code is performant. The consistency is perhaps a
> third priority, if that -- there may be other objectives that are also
> more important than consistency.

Yeah, I was convinced by the discussion in [1], so spent some time to be able
to detect kind of automatically those useless casts.

[1]: https://www.postgresql.org/message-id/flat/461ea37c-8b58-43b4-9736-52884e862820(at)eisentraut(dot)org

Regards,

--
Bertrand Drouvot
PostgreSQL Contributors Team
RDS Open Source Databases
Amazon Web Services: https://aws.amazon.com

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Melanie Plageman 2025-11-20 17:16:37 Re: Odd openbsd CI failure
Previous Message Bertrand Drouvot 2025-11-20 16:59:07 Re: Add os_page_num to pg_buffercache