Re: vacuumdb: add --dry-run

From: Nathan Bossart <nathandbossart(at)gmail(dot)com>
To: Corey Huinker <corey(dot)huinker(at)gmail(dot)com>
Cc: Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: vacuumdb: add --dry-run
Date: 2025-11-19 22:44:03
Message-ID: aR5IMz4cngn8hkXI@nathan
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, Nov 19, 2025 at 05:23:48PM -0500, Corey Huinker wrote:
> Now with zero hangs and some test cases. I didn't create a function (yet)
> as it seemed trivial.

I still think it could be worth moving the dry-run code into
run_vacuum_command() (which might entail moving the calls to
ParallelSlotSetHandler() there, too). We can probably piggy-back on the
"if (echo)" branch in that function.

Also, we can probably skip the executeCommand() calls for
--analyze-in-stages.

--
nathan

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Samuel Thibault 2025-11-19 22:45:07 Re: GNU/Hurd portability patches
Previous Message Thomas Munro 2025-11-19 22:43:53 Re: PRI?64 vs Visual Studio (2022)