| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Andres Freund <andres(at)anarazel(dot)de> |
| Cc: | Nazir Bilal Yavuz <byavuz81(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Postgres hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: make -C src/test/isolation failure in index-killtuples due to btree_gist |
| Date: | 2025-11-19 02:30:30 |
| Message-ID: | aR0rxogaaoBOVDXn@paquier.xyz |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Nov 18, 2025 at 09:00:39AM -0500, Andres Freund wrote:
> On 2025-11-18 08:40:46 +0900, Michael Paquier wrote:
>> By the way, an extra argument in favor of an isolation test here: the
>> proposed TAP tests only wants to make sure that replay is able to
>> finish on a standby, we don't query it.
>
> I think we should eventually extend the test to run amcheck etc on both
> primary and standby.
It's also something that I was wondering we could do after a main
regression test run for some subset of objects. Not sure that it has
to be part of one test.
>> We are already doing the same in 027_stream_regress.pl for the main
>> regression test suite, and we could expand this TAP test or add a new one
>> that grabs the isolation test suite and runs it in a TAP test with a standby
>> plugged.
>
> I don't think we should add new things to 027_stream_regress, it's already one
> of the two slowest tests and, at least for me, often the test that takes the
> longest to complete in a testrun.
Of course, agreed. That's the part about adding a completely new TAP
test that's able to run one or more isolation test suites, and this
isolation test would be part of it when running things across a
standby and a primary. You're the author of the original test, so
your opinion takes priority over mine, for sure.
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tender Wang | 2025-11-19 02:32:48 | Re: Fix typos in ExecChooseHashTableSize() |
| Previous Message | Tom Lane | 2025-11-19 02:28:35 | Re: PRI?64 vs Visual Studio (2022) |