Re: Consistently use the XLogRecPtrIsInvalid() macro

From: Bertrand Drouvot <bertranddrouvot(dot)pg(at)gmail(dot)com>
To: Álvaro Herrera <alvherre(at)kurilemu(dot)de>
Cc: Peter Eisentraut <peter(at)eisentraut(dot)org>, Michael Paquier <michael(at)paquier(dot)xyz>, Heikki Linnakangas <hlinnaka(at)iki(dot)fi>, Quan Zongliang <quanzongliang(at)yeah(dot)net>, pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: Consistently use the XLogRecPtrIsInvalid() macro
Date: 2025-11-06 05:56:47
Message-ID: aQw4n7V1luk1xnrI@ip-10-97-1-34.eu-west-3.compute.internal
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi,

On Mon, Nov 03, 2025 at 07:47:28AM +0000, Bertrand Drouvot wrote:
> I think the way it is done in the attached makes sense, it:
>
> - introduces PG_DEPRECATED()
> - provides a use case on how to use it (i.e using a version that is currently
> in the future)
> - ensures that XLogRecPtrIsInvalid() deprecation is "enforced" as of version 24
> - ensures that not using XLogRecPtrIsInvalid() is documented (so that it should
> not be used anymore, at least in core, even waiting for version 24)

Attached a rebase due to 6d0eba66275 and 447aae13b03.

Regards,

--
Bertrand Drouvot
PostgreSQL Contributors Team
RDS Open Source Databases
Amazon Web Services: https://aws.amazon.com

Attachment Content-Type Size
v5-0001-Introduce-XLogRecPtrIsValid-and-replace-XLogRecPt.patch text/x-diff 49.9 KB
v5-0002-Introduce-PG_DEPRECATED-and-deprecate-XLogRecPtrI.patch text/x-diff 2.6 KB
v5-0003-Replace-InvalidXLogRecPtr-comparisons-with-XLogRe.patch text/x-diff 39.2 KB
v5-0004-Replace-literal-0-comparisons-on-XLogRecPtr-with-.patch text/x-diff 1.9 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Bryan Green 2025-11-06 06:05:06 Re: [Patch] Windows relation extension failure at 2GB and 4GB
Previous Message Mahendra Singh Thalor 2025-11-06 05:33:38 Re: Non-text mode for pg_dumpall