Re: [PATCH] Add error message for out-of-memory in passwordFromFile()

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Joshua Shanks <jjshanks(at)gmail(dot)com>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: [PATCH] Add error message for out-of-memory in passwordFromFile()
Date: 2025-11-04 11:17:02
Message-ID: aQngrpjsKOLZtAii@paquier.xyz
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Mon, Nov 03, 2025 at 09:15:25PM -0800, Joshua Shanks wrote:
> Thank you for the detailed feedback! This is my first C project
> contribution, so I really appreciate you taking the time to explain the
> proper error handling pattern.

No problem. Applied on HEAD after a few tweaks:
* two libpq_gettext() added,
* *errmsg set to NULL when entering passwordFromFile().
* Some rewords.
--
Michael

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Peter Eisentraut 2025-11-04 11:21:27 Re: [PATCH] Fix Korean typo 'checkpoint' in log
Previous Message Fabrice Chapuis 2025-11-04 11:14:54 Re: Issue with logical replication slot during switchover