| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Bertrand Drouvot <bertranddrouvot(dot)pg(at)gmail(dot)com> |
| Cc: | Kirill Reshke <reshkekirill(at)gmail(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: relfilenode statistics |
| Date: | 2025-11-08 23:33:54 |
| Message-ID: | aQ_TYhsZG72QkS_A@paquier.xyz |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Fri, Nov 07, 2025 at 11:28:27AM +0000, Bertrand Drouvot wrote:
> While there are existing rewrite tests, the stats behavior during rewrites
> doesn't have a good coverage. This patch adds some tests to record some stats
> after different rewrite scenarios.
>
> That way, we'll be able to test that the stats are still the ones we
> expect after rewrites. Note that it generates a new stats_1.out (which is quite
> large), so we may want to move those new tests to "isolation" instead.
Looking at this part of the patch set for now, not looked at the rest
yet. This new stats_1.out is 2k lines long, introduced for the tests
related to rewrites as an effect of 2PC. It seems to me that a split
into a new stats_rewrite would be justified for this case, to reduce
the output duplication.
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2025-11-08 23:35:20 | Re: [PATCH] Fix text in comment of copyto.c |
| Previous Message | Thomas Munro | 2025-11-08 22:50:39 | Re: IO in wrong state on riscv64 |