Re: Extend injection_points_attach() to accept a user-defined function

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Rahila Syed <rahilasyed90(at)gmail(dot)com>
Cc: Mihail Nikalayeu <mihailnikalayeu(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Extend injection_points_attach() to accept a user-defined function
Date: 2025-11-08 23:35:55
Message-ID: aQ_T2zQEF4_HxST9@paquier.xyz
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Fri, Nov 07, 2025 at 05:39:57PM +0530, Rahila Syed wrote:
> OK, it makes sense to leave it out of this function for now. Since
> pgstat_create_inj() currently only tracks the number of runs, it also
> depends on any callback using the appropriate pgstat_report_* API
> from the injection_point module. Without this, setting up the stats
> infrastructure wouldn't be useful.

Yeah. What you are doing would be enough on simplicity ground. The
test added is also fine enough, it's safe to run even under an
installcheck. So LGTM to use a minimal implementation. Any thoughts
from others?
--
Michael

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Thomas Munro 2025-11-09 00:29:36 Re: MSVC: Improve warning options set
Previous Message Michael Paquier 2025-11-08 23:35:20 Re: [PATCH] Fix text in comment of copyto.c