Re: abi-compliance-check failure due to recent changes to pg_{clear,restore}_{attribute,relation}_stats()

From: Nathan Bossart <nathandbossart(at)gmail(dot)com>
To: Peter Eisentraut <peter(at)eisentraut(dot)org>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, "David E(dot) Wheeler" <david(at)justatheory(dot)com>, Mankirat Singh <mankiratsingh1315(at)gmail(dot)com>, pg(at)bowt(dot)ie, andrew(at)dunslane(dot)net, pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: abi-compliance-check failure due to recent changes to pg_{clear,restore}_{attribute,relation}_stats()
Date: 2025-10-31 14:09:36
Message-ID: aQTDIO2xjmFKK0QV@nathan
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Fri, Oct 31, 2025 at 12:02:10PM +0100, Peter Eisentraut wrote:
> What is the reason that this file is supposed to contain the history of
> relevant changes, rather than just the last one?
>
> If you want the history, you could look at the git log of the file itself,
> no?

I think either way would ultimately be fine. I might argue that keeping
the full history in a file with detailed explanations is more accessible
than requiring folks to run

git log .abi-compliance-history

(Plus, if someone doesn't bother to put details in the commit message, you
then have to sleuth further to figure out what changed.)

--
nathan

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Karina Litskevich 2025-10-31 14:45:07 Re: doc: Improve description of io_combine_limit and io_max_combine_limit GUCs
Previous Message Gureumi 2025-10-31 14:02:16 [PATCH] Fix Korean typo 'checkpoint' in log