| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Xuneng Zhou <xunengzhou(at)gmail(dot)com> |
| Cc: | Noah Misch <noah(at)leadboat(dot)com>, ryanzxg(at)gmail(dot)com, pgsql-bugs(at)lists(dot)postgresql(dot)org, Euler Taveira <euler(at)eulerto(dot)com> |
| Subject: | Re: BUG #19093: Behavioral change in walreceiver termination between PostgreSQL 14.17 and 14.18 |
| Date: | 2025-10-31 03:16:21 |
| Message-ID: | aQQqBUuRAS38u3w8@paquier.xyz |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-bugs |
On Fri, Oct 31, 2025 at 12:07:01AM +0800, Xuneng Zhou wrote:
> Using a wrapper function seems better here.
For a cleaner git history, the wrapper function and the assertion
should be split as its own commit, with the actual fix applied first.
Just an opinion.
> I’ve incorporated both tests and the assertion into the patch applied to master.
> For earlier stable branches, the test in
> 040_standby_failover_slots_sync.pl and the assertion for
> WAL receiver state checking are not included (if Noah agrees too). Please check.
Thanks for doing that. I have extracted the test to check the "valid"
WAL receiver shutdown case, and applied that separately.
Noah, what do you think?
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | dengkai | 2025-10-31 07:14:57 | [bug report] About create table like feature's bug |
| Previous Message | David Rowley | 2025-10-31 01:50:15 | Re: BUG #19099: Conditional DELETE from partitioned table with non-updatable partition raises internal error |