Re: Extra blank line in StrategyGetBuffer

From: Bruce Momjian <bruce(at)momjian(dot)us>
To: Ashutosh Bapat <ashutosh(dot)bapat(dot)oss(at)gmail(dot)com>
Cc: Andres Freund <andres(at)anarazel(dot)de>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Extra blank line in StrategyGetBuffer
Date: 2025-11-08 02:54:07
Message-ID: aQ6wz0NIX8mSkzt5@momjian.us
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers


Agreed, patch applied, thanks.

---------------------------------------------------------------------------

On Tue, Nov 4, 2025 at 02:27:12PM +0530, Ashutosh Bapat wrote:
> Hi Andres,
> It seems that 5e89985928795f243dc287210c2aa016dfd00bfe left an extra
> line in StrategyGetBetter(). Doesn't seem to be intentional. But it's
> mildly confusing to miss a parentheses on that line. PFA patch fixing
> it.
>
> --
> Best Wishes,
> Ashutosh Bapat

> diff --git a/src/backend/storage/buffer/freelist.c b/src/backend/storage/buffer/freelist.c
> index 7fe34d3ef4c..552fcd0f217 100644
> --- a/src/backend/storage/buffer/freelist.c
> +++ b/src/backend/storage/buffer/freelist.c
> @@ -301,7 +301,6 @@ StrategyGetBuffer(BufferAccessStrategy strategy, uint32 *buf_state, bool *from_r
> return buf;
> }
> }
> -
> }
> }
> }

--
Bruce Momjian <bruce(at)momjian(dot)us> https://momjian.us
EDB https://enterprisedb.com

Do not let urgent matters crowd out time for investment in the future.

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Manni Wood 2025-11-08 04:19:38 Re: [PATCH] Add pg_get_tablespace_ddl() function to reconstruct CREATE TABLESPACE statement
Previous Message Tom Lane 2025-11-08 02:32:45 Re: Support allocating memory for large strings