| From: | Nathan Bossart <nathandbossart(at)gmail(dot)com> |
|---|---|
| To: | Aleksander Alekseev <aleksander(at)tigerdata(dot)com> |
| Cc: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Shinya Kato <shinya11(dot)kato(at)gmail(dot)com>, Álvaro Herrera <alvherre(at)kurilemu(dot)de> |
| Subject: | Re: [PATCH] Remove make_temptable_name_n() |
| Date: | 2025-10-21 19:30:53 |
| Message-ID: | aPffbfbXfHsr776w@nathan |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Oct 21, 2025 at 03:36:46PM +0300, Aleksander Alekseev wrote:
> + {
> + char *nsp = get_namespace_name(RelationGetNamespace(tempRel));
> + char *temprelname = RelationGetRelationName(tempRel);
> + char *diffrelname = psprintf("%s_%d", temprelname, 2);
I assume the intent of the extra set of curly brackets is to keep the
declarations of these variables close to where they are used. In this
case, the top of the function is only a few lines up, so IMHO we should
declare them there and save a level of indentation.
> + pfree(diffrelname);
> + if (nsp)
> + pfree(nsp);
Any reason to be so careful about freeing these? We ordinarily let the
memory context take care of freeing, and refresh_by_match_merge() looks no
different.
--
nathan
| From | Date | Subject | |
|---|---|---|---|
| Next Message | David Rowley | 2025-10-21 20:07:33 | Re: another autovacuum scheduling thread |
| Previous Message | Alexander Borisov | 2025-10-21 19:20:21 | Unicode 17 |