Re: Fix incorrect comment in pg_get_shmem_allocations_numa()

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Bertrand Drouvot <bertranddrouvot(dot)pg(at)gmail(dot)com>
Cc: PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Tomas Vondra <tomas(at)vondra(dot)me>
Subject: Re: Fix incorrect comment in pg_get_shmem_allocations_numa()
Date: 2025-10-21 07:14:39
Message-ID: aPcy39HGeEcHJP3Z@paquier.xyz
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Mon, Jul 21, 2025 at 09:06:22AM +0000, Bertrand Drouvot wrote:
> One comment in pg_get_shmem_allocations_numa() incorrectly describes the function
> as dealing with database blocks when it actually processes shared memory allocations
> from the shmem index.

(Noticed this one while browsing the CF app.)

Yep, agreed that the comment deserves a better explanation, so applied
down to v18.
--
Michael

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paquier 2025-10-21 07:18:09 Re: pgbench: extend variable usage in scripts
Previous Message Heikki Linnakangas 2025-10-21 07:10:38 Re: Optimizing ResouceOwner to speed up COPY