Re: BRIN: Prevent the heapblk overflow during index summarization on very large tables resulting in an infinite loop

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: David Rowley <dgrowleyml(at)gmail(dot)com>
Cc: sunil s <sunilfeb26(at)gmail(dot)com>, pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: BRIN: Prevent the heapblk overflow during index summarization on very large tables resulting in an infinite loop
Date: 2025-10-21 05:53:33
Message-ID: aPcf3XJ72Lk-7JRy@paquier.xyz
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Tue, Oct 21, 2025 at 06:32:01PM +1300, David Rowley wrote:
> I'd leave it as uint64. There's no reason to mixup the signedness
> between these two variables.

That's fine as well.

> I'm happy to finish this one off. I was leaving it for Tomas to
> comment, but I think he'll be busy with pgconf.eu for the next few
> days.

Cool, thanks. I'm leaving that stuff up to any of you, have fun.
FWIW, I am on the same line as you. Your suggestions are better than
what the proposed patch does, as far as I've looked.
--
Michael

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paquier 2025-10-21 05:57:00 Re: Extended Statistics set/restore/clear functions.
Previous Message Michael Paquier 2025-10-21 05:48:37 Re: Extended Statistics set/restore/clear functions.