| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | David Rowley <dgrowleyml(at)gmail(dot)com> |
| Cc: | PostgreSQL Developers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Use CompactAttribute more often, when possible |
| Date: | 2025-10-20 08:15:34 |
| Message-ID: | aPXvpi2UVkfGGL_m@paquier.xyz |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, Oct 20, 2025 at 05:46:33PM +1300, David Rowley wrote:
> I don't think the attached is very interesting to look at, but l'll
> leave it here for a bit just in case anyone wants to look. Otherwise,
> I plan to just treat it as a follow-up of 5983a4cff.
Still I've looked at it. I like reading code.
The change in validateDomainCheckConstraint()@typecmds.c looks
independent to what you are suggesting here. Grouping that is fine,
just noting that the intent is not the same.
@@ -5146,10 +5146,6 @@ ReorderBufferToastReplace(ReorderBuffer *rb, ReorderBufferTXN *txn,
dlist_iter it;
Size data_done = 0;
- /* system columns aren't toasted */
- if (attr->attnum < 0)
- continue;
Er, why this removal?
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Chao Li | 2025-10-20 08:34:14 | Re: Use CompactAttribute more often, when possible |
| Previous Message | Jakub Wartak | 2025-10-20 08:10:25 | Re: [PATCH] Add Windows support for backtrace_functions (MSVC only) |