Re: abi-compliance-check failure due to recent changes to pg_{clear,restore}_{attribute,relation}_stats()

From: Nathan Bossart <nathandbossart(at)gmail(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: pgsql-hackers(at)postgresql(dot)org, david(at)justatheory(dot)com, Andrew Dunstan <andrew(at)dunslane(dot)net>
Subject: Re: abi-compliance-check failure due to recent changes to pg_{clear,restore}_{attribute,relation}_stats()
Date: 2025-10-17 19:35:12
Message-ID: aPKacE_vakRY17FV@nathan
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Fri, Oct 17, 2025 at 03:27:10PM -0400, Tom Lane wrote:
> Nathan Bossart <nathandbossart(at)gmail(dot)com> writes:
>> I've attached a first try. You'll notice that I have borrowed heavily from
>> .git-blame-ignore-revs. Some other things that might be worthwhile:
>
> There would need to be an initial entry at the time the file is
> created, which would presumably point to some commit shortly before
> the .0 version stamp is applied (or maybe we'd choose to do it around
> rc1). The mockup should include that.

Sure, makes sense.

> I'd be slightly inclined to have just one non-comment line, which
> is the active reference hash value, and all the rest be comments.
> The way you have it here requires the reading code to be smart
> about end-of-line comments, which is code complexity we don't need
> and doesn't seem amazingly legible either. OTOH, the precedent of
> .git-blame-ignore-revs may be worth following regardless of our
> personal druthers.

That crossed my mind, too. I'm personally not too concerned about small
deviations from .git-blame-ignore-revs, especially if it improves
machine/human readability.

--
nathan

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Nathan Bossart 2025-10-17 19:39:15 Re: abi-compliance-check failure due to recent changes to pg_{clear,restore}_{attribute,relation}_stats()
Previous Message Peter Geoghegan 2025-10-17 19:33:28 Re: abi-compliance-check failure due to recent changes to pg_{clear,restore}_{attribute,relation}_stats()