Re: get rid of RM_HEAP2_ID

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: John Naylor <johncnaylorls(at)gmail(dot)com>
Cc: PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: get rid of RM_HEAP2_ID
Date: 2025-10-10 02:46:53
Message-ID: aOhznflGkNKQ4Mho@paquier.xyz
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thu, Oct 09, 2025 at 03:15:11PM +0700, John Naylor wrote:
> Leaving that up to the rmgr makes sense. One consideration I didn't
> mention was for xlogstats.c -- "record_stats[rmid][recid]" would get
> 16x larger if recid could take up the full byte. Maybe that's
> harmless, but I didn't want to assume. Any thoughts on that?

I've missed this interaction, thanks for mentioning it. XLogStats is
a local state that's only used by pg_walinspect and pg_waldump, so
this extra memory consumed does worry me much; this stuff interacts
with no critical paths.
--
Michael

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message jian he 2025-10-10 02:54:47 Re: speedup COPY TO for partitioned table.
Previous Message Michael Paquier 2025-10-10 02:32:20 Re: [PATCH TEST] Fix logical replication setup in subscription test `t/009_matviews.pl`