Re: compiling pg_bsd_indent

On Thu, Oct 09, 2025 at 11:49:31AM -0400, Andres Freund wrote:
> On 2025-10-09 11:43:57 -0400, Robert Haas wrote:
>> While $SUBJECT today -- using the sources from
>> https://git.postgresql.org/git/pg_bsd_indent.git -- I ran into some
>> problems. I got errors due to the replacement of
>> pg_attribute_noreturn() with pg_return(), and warnings due to variable
>> definitions with no previous extern declaration. Here's a quick and
>> dirty patch.
>
> I thought we basically only used the in-tree pg_bsd_indent these days?

That's what I thought, too (see commit 4e831f4). FWIW the problem in err.h
was fixed in-tree in the same way as your patch by commit 3691edf. The
missing-externs ones were fixed by adding -Wmissing-variable-declarations,
per commit 6618891.

--
nathan