| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Kirill Reshke <reshkekirill(at)gmail(dot)com> |
| Cc: | Andrey Borodin <x4mmm(at)yandex-team(dot)ru>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Remove custom redundant full page write description from GIN |
| Date: | 2025-10-08 05:14:06 |
| Message-ID: | aOXzHsq8YYdxZ-RC@paquier.xyz |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Oct 07, 2025 at 02:08:02PM +0500, Kirill Reshke wrote:
> Turns out we already use XLogRecGetData in assignment: char *rec =
> XLogRecGetData(record). But I still did alter v2 patch a bit,
> introducing new variable xlrec, to avoid clunky casts between char *
> and ginxlogUpdateMeta.
For UPDATE_META_PAGE, ntuples == 0 could also mean that we may show
a lot of invalid block numbers, as well, which feels a bit pointless.
I have switched that to check InvalidBlockNumber instead.
While reviewing the whole, I have noticed that rightlink was missing
for INSERT_LISTPAGE, as well as the right/left children pages for
SPLIT. I have added this information, applied the result. Thanks!
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Amit Kapila | 2025-10-08 05:35:54 | Re: Logical Replication of sequences |
| Previous Message | Bertrand Drouvot | 2025-10-08 05:02:03 | Re: Add memory_limit_hits to pg_stat_replication_slots |