Re: Remove custom redundant full page write description from GIN

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Andrey Borodin <x4mmm(at)yandex-team(dot)ru>
Cc: Kirill Reshke <reshkekirill(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Remove custom redundant full page write description from GIN
Date: 2025-10-07 06:46:10
Message-ID: aOS3MlTUTAm8GO8A@paquier.xyz
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, Oct 01, 2025 at 03:39:35PM +0900, Michael Paquier wrote:
> + int32 ntuples;
> + ntuples = ((ginxlogUpdateMeta *) rec)->ntuples;
> + appendStringInfo(buf, "ntuples: %d", ntuples);
>
> In 0002. We have a routine for this type of assignments:
> XLogRecGetBlockData(). Let's use it here for clarity.

This should be XLogRecGetData(), not XLogRecGetBlockData(), as the
data is assigned to the record. My apologies for the mistake.
--
Michael

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message ls7777 2025-10-07 06:52:03 Re: Patch for migration of the pg_commit_ts directory
Previous Message Amit Kapila 2025-10-07 06:39:01 Re: Logical Replication of sequences