Re: BUG #19086: pg_dump --data-only selects and do not uses index definitions for the dumped tables.

From: Nathan Bossart <nathandbossart(at)gmail(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: andrewbille(at)gmail(dot)com, pgsql-bugs(at)lists(dot)postgresql(dot)org
Subject: Re: BUG #19086: pg_dump --data-only selects and do not uses index definitions for the dumped tables.
Date: 2025-10-14 22:03:12
Message-ID: aO7IoIEnQDbtFzrs@nathan
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-bugs

On Tue, Oct 14, 2025 at 03:50:15PM -0400, Tom Lane wrote:
> Even if it's been seen in the field, it hardly qualifies as a
> justification for complicating pg_dump's behavior. There's no reason
> to think that catalog corruption preferentially affects indexes, or
> does so in this particular way. Should we also not collect data on
> functions, types, etc etc?

FWIW the getIndexes() query does tend to be one of the slowest, even with
intact system indexes. I've no concrete proposals, but there might be some
room for improvement. I don't think we gain all that much by simply
avoiding the query in probably-somewhat-rare use-cases. IMHO it ought to
be reworked for efficiency.

--
nathan

In response to

Responses

Browse pgsql-bugs by date

  From Date Subject
Next Message David Rowley 2025-10-14 23:56:25 Re: BUG #19086: pg_dump --data-only selects and do not uses index definitions for the dumped tables.
Previous Message David Rowley 2025-10-14 21:44:19 Re: BUG #19078: Segfaults in tts_minimal_store_tuple() following pg_upgrade