From: | Michael Paquier <michael(at)paquier(dot)xyz> |
---|---|
To: | David Rowley <dgrowleyml(at)gmail(dot)com> |
Cc: | Greg Burd <greg(at)burd(dot)me>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
Subject: | Re: [PATCH] Add tests for Bitmapset |
Date: | 2025-10-01 05:14:45 |
Message-ID: | aNy4xV4Fa1m9lyXX@paquier.xyz |
Views: | Whole Thread | Raw Message | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Wed, Oct 01, 2025 at 06:00:59PM +1300, David Rowley wrote:
> I didn't look at the coverage report, but on thinking about it,
> test_bitmapset.c's "PG_RETURN_NULL(); /* invalid input */" won't be
> covered as I stripped out all the tests which purposefully pass
> invalid input. You may not want it that way if you're keen to keep the
> coverage of the test module high as well as bitmapset.c
Yes, that's something I was just going through, with a result pretty
close to what you have sent, including the removal and replacement of
most of tests that were specific to the test module. The prev/next
member coverage is still looking OK from here, though.
Thanks for the typos, I've missed these.
--
Michael
From | Date | Subject | |
---|---|---|---|
Next Message | Joel Jacobson | 2025-10-01 05:47:27 | Re: Optimize LISTEN/NOTIFY |
Previous Message | David Rowley | 2025-10-01 05:01:51 | Re: [PATCH] Add tests for Bitmapset |