Re: [PATCH] Add tests for Bitmapset

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: David Rowley <dgrowleyml(at)gmail(dot)com>
Cc: Greg Burd <greg(at)burd(dot)me>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: [PATCH] Add tests for Bitmapset
Date: 2025-09-30 00:51:03
Message-ID: aNspd6syEndiEPNj@paquier.xyz
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Tue, Sep 30, 2025 at 01:19:05PM +1300, David Rowley wrote:
> NULL is a valid Bitmapset, so I don't really see the need to check for
> an empty set before calling bms_free(). If those were removed, then
> you'd not have to care about the coverage of that line.

Yeah, we could just remove them as you are suggesting, as well.
--
Michael

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Yugo Nagata 2025-09-30 01:23:53 Re: Suggestion to add --continue-client-on-abort option to pgbench
Previous Message Michael Paquier 2025-09-30 00:41:09 Re: Incorrect logic in XLogNeedsFlush()