Re: [PATCH] Add tests for Bitmapset

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Greg Burd <greg(at)burd(dot)me>
Cc: PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: [PATCH] Add tests for Bitmapset
Date: 2025-09-29 23:39:56
Message-ID: aNsYzCYjPV2VQd3o@paquier.xyz
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Mon, Sep 29, 2025 at 06:27:01AM -0400, Greg Burd wrote:
> Yes, I think that does it. Thanks so much for the guidance and help
> taking this to its logical end. I greatly appreciate your guidance and time.

The latest coverage report confirms 100% for bitmapset.c

The only two code paths I'm seeing as not covered are:
- test_bms_add_range() for a bms_free() case.
- test_bms_make_singleton() on NULL input, because the function is
created as strict:
=# select proisstrict from pg_proc
where proname = 'test_bms_make_singleton';
proisstrict
-------------
t
(1 row)

I'm not planning to bother about these, so we are good here.
--
Michael

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Chao Li 2025-09-29 23:46:25 Re: [PATCH] GROUP BY ALL
Previous Message Jacob Champion 2025-09-29 22:15:37 Re: Support getrandom() for pg_strong_random() source