| From: | Bertrand Drouvot <bertranddrouvot(dot)pg(at)gmail(dot)com> |
|---|---|
| To: | Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> |
| Cc: | shveta malik <shveta(dot)malik(at)gmail(dot)com>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: Add memory_limit_hits to pg_stat_replication_slots |
| Date: | 2025-09-26 05:26:08 |
| Message-ID: | aNYj8L5rYYTJslk8@ip-10-97-1-34.eu-west-3.compute.internal |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi,
On Thu, Sep 25, 2025 at 12:14:04PM -0700, Masahiko Sawada wrote:
> On Thu, Sep 25, 2025 at 3:17 AM Bertrand Drouvot
> <bertranddrouvot(dot)pg(at)gmail(dot)com> wrote:
> >
> > That probably means that mem_exceeded_count would need to be increased.
> >
> > What do you think?
>
> Right. But one might argue that if we increment mem_exceeded_count
> only when serializing or streaming is actually performed,
> mem_exceeded_count would be 0 in the first example and therefore users
> would be able to simply check mem_exceeded_count without any
> computation.
Right but we'd not be able to see when the memory limit has been reached for all
the cases (that would hide the aborted transactions case). I think that with
the current approach we have the best of both world (even if it requires some
computations).
Regards,
--
Bertrand Drouvot
PostgreSQL Contributors Team
RDS Open Source Databases
Amazon Web Services: https://aws.amazon.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | shveta malik | 2025-09-26 05:42:56 | Re: POC: enable logical decoding when wal_level = 'replica' without a server restart |
| Previous Message | Michael Paquier | 2025-09-26 03:56:12 | Re: Add support for entry counting in pgstats |