| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com> |
| Cc: | Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Remove unused for_all_tables field from AlterPublicationStmt |
| Date: | 2025-09-26 02:49:43 |
| Message-ID: | aNX_R1rY6AzQ25-k@paquier.xyz |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Fri, Sep 26, 2025 at 09:24:03AM +0800, Chao Li wrote:
> On Sep 26, 2025, at 04:47, Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> wrote:
>> I found that the for_all_table field in the AlterPublicationStmt is
>> not used at all unless I'm missing something. I've attached the patch
>> for only master that removes it.
>
> Yep, based on code of gram.y and the doc, FOR ALL TABLE is only
> supposed by CREATE PUBLICATION.
Indeed, good catch. There's no point for this field currently. As
far as I can see it is wrong since 665d1fad99e7, so I am betting on a
rebase mistake when the original feature has been reviewed.
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Yugo Nagata | 2025-09-26 02:52:34 | Re: Suggestion to add --continue-client-on-abort option to pgbench |
| Previous Message | Yugo Nagata | 2025-09-26 02:44:42 | Re: Suggestion to add --continue-client-on-abort option to pgbench |