| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Sami Imseih <samimseih(at)gmail(dot)com> |
| Cc: | Mircea Cadariu <cadariu(dot)mircea(at)gmail(dot)com>, Frédéric Yhuel <frederic(dot)yhuel(at)dalibo(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Benoit Lobréau <benoit(dot)lobreau(at)dalibo(dot)com>, Guillaume Lelarge <guillaume(dot)lelarge(at)dalibo(dot)com>, Pierrick Chovelon <pierrick(dot)chovelon(at)dalibo(dot)com> |
| Subject: | Re: [BUG] temporary file usage report with extended protocol and unnamed portals |
| Date: | 2025-09-18 06:53:47 |
| Message-ID: | aMuse89cJOtvGRwB@paquier.xyz |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Sep 17, 2025 at 10:52:31AM -0500, Sami Imseih wrote:
> > One argument for keeping the tests would be that they nicely bring together the side-effect (logging) and these use-cases, whereas in the code they're pretty distant, making the connection not obvious.
>
> Another argument is that we have no coverage on temp logging, which
> is why this bug was discovered. There are likely plenty of tools
> out there, for example pgbadger or manual log analysis, that
> have probably misinterpreted temporary usage all this time,
> because of the way the data was emitted.
Perhaps this is a sign that there is no need to be really aggressive
with backpatching aanything, as well. At least that's my impression.
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2025-09-18 07:06:17 | Re: [BUG] temporary file usage report with extended protocol and unnamed portals |
| Previous Message | Yugo Nagata | 2025-09-18 06:33:30 | Re: pgbench: extend variable usage in scripts |