| From: | Nathan Bossart <nathandbossart(at)gmail(dot)com> |
|---|---|
| To: | Sami Imseih <samimseih(at)gmail(dot)com> |
| Cc: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: GetNamedLWLockTranche crashes on Windows in normal backend |
| Date: | 2025-09-17 16:19:41 |
| Message-ID: | aMrfnai23uicAEO7@nathan |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Sep 17, 2025 at 11:08:12AM -0500, Sami Imseih wrote:
>> On Tue, Sep 16, 2025 at 04:04:39PM -0500, Sami Imseih wrote:
>> > startup tranches should be:
>> >
>> > #define NUM_STARTUP_TRANCHES (2)
>> >
>> > instead of:
>> >
>> > #define NUM_STARTUP_TRANCHES (256 - 2)
>>
>> Why?
>
> It does not really matter for the tests being done, but it just
> seems odd that you would create 254 tranches during startup and
> leave room for only 2 dynamic tranches. It is not the typical
> pattern out there, in my opinion.
Okay. I changed it in v8.
--
nathan
| Attachment | Content-Type | Size |
|---|---|---|
| v8-0001-test_lwlock_tranches.patch | text/plain | 11.4 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Nathan Bossart | 2025-09-17 16:21:10 | Re: Remove PointerIsValid() |
| Previous Message | Sami Imseih | 2025-09-17 16:08:12 | Re: GetNamedLWLockTranche crashes on Windows in normal backend |