| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Matthias van de Meent <boekewurm+postgres(at)gmail(dot)com> |
| Cc: | "Madhukar (dot)" <madhukarprasad(at)google(dot)com>, pgsql-hackers(at)postgresql(dot)org, Vaibhav Jain <jainva(at)google(dot)com>, Sangeetha Seshadri <sangsesh(at)google(dot)com>, Noah Misch <nmisch(at)google(dot)com> |
| Subject: | Re: AioCtl Shared Memory size fix |
| Date: | 2025-09-16 06:50:20 |
| Message-ID: | aMkIrBc_6IjPdln2@paquier.xyz |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, Sep 15, 2025 at 02:06:03PM +0200, Matthias van de Meent wrote:
> Presumably this was `PgAioHandle io_handles[]` at some point, but now
> that it's a pointer it's a proper part of the struct's own size, and
> should be treated as such for memory accounting.
I would bet on a FLEXIBLE_ARRAY_MEMBER from a previous version..
>> Please find a patch to account for io_handles member of PgAioCtl.
>> The patch uses sizeof(PgAioCtl) instead of offsetof(PgAioCtl, io_handles) in AioCtlShmemSize.
>
> LGTM.
Yep, will fix. Thanks for the report, the patch and the review, to
both of you.
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Dmitry Mityugov | 2025-09-16 07:21:30 | Re: --with-llvm on 32-bit platforms? |
| Previous Message | John Naylor | 2025-09-16 06:46:55 | Re: [PATCH] Refactor bytea_sortsupport(), take two |