| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Dean Rasheed <dean(dot)a(dot)rasheed(at)gmail(dot)com> |
| Cc: | Peter Eisentraut <peter(at)eisentraut(dot)org>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com>, Postgres hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Remove traces of long in dynahash.c |
| Date: | 2025-09-10 05:33:40 |
| Message-ID: | aMENtE9cqL8nAW5o@paquier.xyz |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Sep 09, 2025 at 10:28:13AM +0100, Dean Rasheed wrote:
> So I think there's no point in adding that cap, or any additional
> checks in ExecChooseHashTableSize().
You are right that this hardcoded limit introduced in the previous
patch was useless. So I have removed that, and applied the result.
Thanks for the suggestion.
Regarding removing the next power functions in dynahash.c, I am not
sure if it is worth bothering much. Now that dynahash.h is removed,
all the code duplication that was in the backend, without the
hardcoded thresholds, is removed.
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | David Rowley | 2025-09-10 06:20:16 | Re: Query Performance Degradation Due to Partition Scan Order – PostgreSQL v17.6 |
| Previous Message | Chao Li | 2025-09-10 05:19:59 | Re: Mark ItemPointer arguments as const thoughoutly |