Re: pg_upgrade: transfer pg_largeobject_metadata's files when possible

From: Nathan Bossart <nathandbossart(at)gmail(dot)com>
To: Michael Paquier <michael(at)paquier(dot)xyz>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Nitin Motiani <nitinmotiani(at)google(dot)com>, Hannu Krosing <hannuk(at)google(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: pg_upgrade: transfer pg_largeobject_metadata's files when possible
Date: 2025-09-05 18:12:49
Message-ID: aLsoIeIxlCi-L7C_@nathan
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Fri, Sep 05, 2025 at 03:35:21PM +0900, Michael Paquier wrote:
> + $old->safe_psql('postgres', q|
> + CREATE EXTENSION dummy_seclabel;
>
> Still I think that this bit is going to fail with installcheck,
> because src/test/modules/ is not installed by default :)
>
> You can make that conditional with check_extension(), like the tricks
> for injection_points in other TAP tests. The security label creation
> and test also need to be made conditional. The work is already done
> with the check on oldinstall, it just needs an extra tweak, so I would
> store the condition in a separate variable at the top of test_mode()
> in 006_transfer_modes.pl, or something equivalent.

How does this look?

--
nathan

Attachment Content-Type Size
v3-0001-pg_upgrade-Transfer-pg_largeobject_metadata-s-fil.patch text/plain 15.1 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Greg Burd 2025-09-05 18:26:06 Re: [PATCH] Let's get rid of the freelist and the buffer_strategy_lock
Previous Message Ashutosh Sharma 2025-09-05 18:09:45 Re: Improve pg_sync_replication_slots() to wait for primary to advance