Re: Use bool with synced field (src/include/replication/slot.h)

From: Nathan Bossart <nathandbossart(at)gmail(dot)com>
To: Ranier Vilela <ranier(dot)vf(at)gmail(dot)com>
Cc: Pg Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Use bool with synced field (src/include/replication/slot.h)
Date: 2025-09-02 21:02:47
Message-ID: aLdbdy4P5QT06Out@nathan
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Tue, Sep 02, 2025 at 11:02:37AM -0500, Nathan Bossart wrote:
> LGTM. In the original thread, it looks like this was added in v32 [0] and
> effectively switched to a bool in v58 [1].

I was worried that we might need to bump SLOT_VERSION for this, but I see
that as of v18 [0], we require sizeof(bool) == 1. So I think it can be
applied as-is, which I'm planning to do shortly.

[0] https://postgr.es/c/97525bc5c8

--
nathan

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Alexander Borisov 2025-09-02 21:07:00 Re: Improve the performance of Unicode Normalization Forms.
Previous Message Mikhail Kot 2025-09-02 20:09:54 Fix segfault while accessing half-initialized hash table in pgstat_shmem.c