| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Amul Sul <sulamul(at)gmail(dot)com> |
| Cc: | Dean Rasheed <dean(dot)a(dot)rasheed(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Refactoring: Use soft error reporting for *_opt_error functions |
| Date: | 2025-09-02 07:29:16 |
| Message-ID: | aLaczOzuVoBQeCOy@paquier.xyz |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Sep 02, 2025 at 12:40:25PM +0530, Amul Sul wrote:
> Just a quick question regarding the naming conventions. It looks like
> we have a choice between two options for consistency. Should we rename
> the pg_lsn_in_internal function by replacing "_internal" with "_safe",
> or should we rename all of the *_opt_error functions by replacing
> "_opt_error" with "_internal"?
>
> I would choose the latter option.
Applying "_safe" seems a bit more consistent to me, as per past
changes like ccff2d20ed96, also looking at the functions that are
given a ErrorSaveContext in input. I am ready to believe that there
are not a lot of callers of the existing _opt_error() routines listed
in numeric.h, so a renaming may be better to let existing callers know
about the change. These predate the introduction of the "_safe"
functions, introduced in 16d489b0fe05.
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Shlok Kyal | 2025-09-02 07:32:23 | Fix use of variable after pfree |
| Previous Message | Srirama Kucherlapati | 2025-09-02 07:26:32 | Concurrency Issue with pg_ctl causing processes to hang in PostgreSQL 15.12 |