Re: Serverside SNI support in libpq

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Daniel Gustafsson <daniel(at)yesql(dot)se>
Cc: Andres Freund <andres(at)anarazel(dot)de>, Jacob Champion <jacob(dot)champion(at)enterprisedb(dot)com>, Pgsql Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Serverside SNI support in libpq
Date: 2025-09-01 01:58:29
Message-ID: aLT9xVsTVp0j3zWy@paquier.xyz
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, Aug 27, 2025 at 09:49:34PM +0200, Daniel Gustafsson wrote:
> When looking into why the SNI tests failed on Windows I think I found a
> pre-existing issue that we didn't have tests for, which my patch added tests
> for and thus broke.
>
> The test I added was to check restarting and reloading with ssl passphrase
> commands (which we do have testcoverage for) with a subsequent connection test
> to ensure it didn't just work to start the cluster.

Would this part be better if extracted from the main patch and then
backpatched? Even if not backpatched, a split would be cleaner on
HEAD, I assume, leading to less fuzz with the main patch.
--
Michael

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paquier 2025-09-01 02:03:55 Re: Buffer locking is special (hints, checksums, AIO writes)
Previous Message Michael Paquier 2025-09-01 01:53:41 Re: Generate pgstat_count_slru*() functions for slru using macros