| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Peter Smith <smithpb2250(at)gmail(dot)com> |
| Cc: | Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com>, Shlok Kyal <shlok(dot)kyal(dot)oss(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Kirill Reshke <reshkekirill(at)gmail(dot)com> |
| Subject: | Re: Remove redundant assignment of a variable in function AlterPublicationTables |
| Date: | 2025-08-22 05:32:22 |
| Message-ID: | aKgA5lw4sFe8G9AS@paquier.xyz |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Fri, Aug 22, 2025 at 09:55:23AM +1000, Peter Smith wrote:
> To summarise:
> Only ~4 places are redundantly assigning isNull values before calling
> functions that use &isNull.
> But ~400 function calls that are passing &isNull do not pre-assignment
> of that variable.
>
> Choosing to keep this patch would be consistent with 99% of existing examples.
Sure, but I don't quite see what really requires fixing here. Even if
there's an "inconsistency" with variable manipulation pattern, it
does not present a risk of becoming broken if we begin to manipulate
or refactor this area of the code, nor do we need to force one rule
across the whole source code. I'd suggest to keep this one for
patches that rework the whole area, if these churns prove to be
annoying.
If somebody else wants to come around and apply this patch, I'm OK
with that, of course, my opinion is just one voice among many others.
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Kirill Reshke | 2025-08-22 05:36:30 | Re: Remove unneeded cast in heap_xlog_lock. |
| Previous Message | Michael Paquier | 2025-08-22 05:23:22 | Re: Remove unneeded cast in heap_xlog_lock. |