Re: pgsql: Move SQL-callable code related to multixacts into its own file

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Álvaro Herrera <alvherre(at)kurilemu(dot)de>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: Re: pgsql: Move SQL-callable code related to multixacts into its own file
Date: 2025-08-20 08:11:05
Message-ID: aKWDGckk3K2ftiPw@paquier.xyz
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-committers

On Tue, Aug 19, 2025 at 12:31:14PM +0200, Alvaro Herrera wrote:
> Hmm, don't you find strange that dbcommands.h is still included there?
> I wondered about that and found out that we have get_database_name()
> declared there. It sort-of makes sense, because it was originally done
> by scanning pg_database, but since commit cb98e6fb8fd4 introduced a
> syscache for it, we can have this routine in lsyscache.c/h instead,
> where it feels more at home. It also seems more sensible to declare
> get_database_oid() in pg_database.h. After these two changes, a lot of
> files can stop including dbcommands.h. This seems a nice cleanup to me,
> and passes headerscheck.
>
> 33 files changed, 39 insertions(+), 56 deletions(-)

Indeed, that's a nice located cleanup.
--
Michael

In response to

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2025-08-20 12:17:26 Re: pgsql: Move SQL-callable code related to multixacts into its own file
Previous Message Michael Paquier 2025-08-20 06:00:43 pgsql: Fix assertion failure with replication slot release in single-us