Re: Report reorder buffer size

From: Bertrand Drouvot <bertranddrouvot(dot)pg(at)gmail(dot)com>
To: Ashutosh Bapat <ashutosh(dot)bapat(dot)oss(at)gmail(dot)com>
Cc: pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Report reorder buffer size
Date: 2025-08-27 07:31:57
Message-ID: aK60bWYkyub/UOuk@ip-10-97-1-34.eu-west-3.compute.internal
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi,

On Tue, Aug 26, 2025 at 09:48:04AM +0000, Bertrand Drouvot wrote:
> Hi,
>
> On Tue, Aug 26, 2025 at 02:56:14PM +0530, Ashutosh Bapat wrote:
> > On Mon, Aug 25, 2025 at 6:28 PM Bertrand Drouvot
> > <bertranddrouvot(dot)pg(at)gmail(dot)com> wrote:
> > > > I didn't know this is how it works. Thanks for correcting me. In that
> > > > case, I think we should
> > > > add a column in pg_stat_replication_slots reporting the number of
> > > > times the memory limit is reached since the last reset. I am +0.5 on
> > > > it being useful.
> > >
> > > Thanks. With this in place one could get a ratio like total_txns/total_txns_that_exceeds.
> > > That could help to see if reaching logical_decoding_work_mem is rare or
> > > frequent enough. If frequent, then maybe there is a need to adjust logical_decoding_work_mem.
> > >
> >
> > We are discussing some improvements to pg_stat_replication_slots over
> > at [1]. Would you be able to create a patch reporting the number of
> > times logical_decoding_work_mem is reached, in the patchset being
> > discussed there?
> >
> > [1] https://www.postgresql.org/message-id/CAExHW5s6KntzUyUoMbKR5dgwRmdV2Ay_2+AnTgYGAzo=Qv61wA@mail.gmail.com
>
> Thanks for pointing me to this thread, I'll look at it and propose a patch
> to report the number of times logical_decoding_work_mem is reached.

I preferred to create a dedicated thread for it [1] (I think both may need dedicated
discussions).

[1]: https://www.postgresql.org/message-id/flat/aK6zNcmb%2BPpySFvG%40ip-10-97-1-34.eu-west-3.compute.internal

Regards,

--
Bertrand Drouvot
PostgreSQL Contributors Team
RDS Open Source Databases
Amazon Web Services: https://aws.amazon.com

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Dmitry 2025-08-27 07:55:34 Re: Inconsistent update in the MERGE command
Previous Message Bertrand Drouvot 2025-08-27 07:26:45 Add memory_limit_hits to pg_stat_replication_slots