Re: Annoying warning in SerializeClientConnectionInfo

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Jacob Champion <jacob(dot)champion(at)enterprisedb(dot)com>
Cc: Andres Freund <andres(at)anarazel(dot)de>, pgsql-hackers(at)postgresql(dot)org, Andy Fan <zhihuifan1213(at)163(dot)com>
Subject: Re: Annoying warning in SerializeClientConnectionInfo
Date: 2025-08-14 07:23:46
Message-ID: aJ2PAhOqhsC7eDXj@paquier.xyz
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, Aug 13, 2025 at 08:30:19AM -0700, Jacob Champion wrote:
> On Wed, Aug 13, 2025 at 8:28 AM Andres Freund <andres(at)anarazel(dot)de> wrote:
>> I think we shouldn't add the attribute to the declaration, just to the
>> function. The caller doesn't need to know that it's unused, it's purely a
>> question of the specific implementation that the attribute is unused.
>
> +1

Okay, done so only in the function, then.
--
Michael

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Nazir Bilal Yavuz 2025-08-14 07:37:09 Re: meson: Add _static and _shared suffixes to the library names
Previous Message David Rowley 2025-08-14 07:14:54 Re: Support tid range scan in parallel?