Re: BUG #18964: `ALTER DATABASE ... RESET ...` fails to reset extension parameters that no longer exist

On Mon, Jul 28, 2025 at 05:27:50PM -0400, Tom Lane wrote:
> Nathan Bossart <nathandbossart(at)gmail(dot)com> writes:
>> I looked into how easily this back-patched to v15 (where commit 88103567c
>> was added), and I noticed that the ALTER SYSTEM code looks a bit different
>> on v15 and v16. Furthermore, I didn't see a simple way to fix it on those
>> versions without first back-patching commit 2d870b4. From the commit
>> message, it looks like Tom didn't back-patch it at the time due to a lack
>> of complaints. I'm currently thinking we should first back-patch that one
>> to at least v15, if not all supported versions, before applying my proposed
>> patch. Thoughts?
>
> No objection here. Now that that's a couple years old, it should have
> had enough time to bake.

It applies relatively cleanly down to v15. The only thing I had to change
was to replace guc_free() with free() on v15. I was a little worried about
changing the signature of check_GUC_name_for_parameter_acl(), but
codesearch.debian.net doesn't show any outside uses.

--
nathan