Re: Broken ./configure checks for __cpuid() and __cpuidex()

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Lukas Fittl <lukas(at)fittl(dot)com>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Postgres hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Broken ./configure checks for __cpuid() and __cpuidex()
Date: 2025-07-30 08:13:50
Message-ID: aInUPnGWP2QwBeg-@paquier.xyz
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, Jul 30, 2025 at 12:02:44PM +0900, Michael Paquier wrote:
> On Tue, Jul 29, 2025 at 12:21:32AM -0700, Lukas Fittl wrote:
>> FWIW, I looked again at the MinGW sources and I think you're right that
>> intrin.h is likely also correct for MinGW. I originally thought that
>> cpuid.h would be correct, given that's whats used by GCC/clang, but I think
>> the MinGW source itself is authoritative here (vs the compiler in use), and
>> that has a intrin.h include ([0]) but no cpuid.h.
>
> Yeah. I have a close of MinGW locally, and that matches what I saw.

s/close/clone/.

> Applied on all the branches. Let's wait for the buildfarm to report,
> now.

The first reports are popping up for the Windows animals, and as far
as I can see things seem to tbe OK for now in terms of the flavors of
__cpuid & friends detected, for the mix of meson, MinGW, MSVC and
configure that we have.
--
Michael

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Andrei Lepikhov 2025-07-30 08:20:52 Re: track generic and custom plans in pg_stat_statements
Previous Message Peter Eisentraut 2025-07-30 08:07:32 Improve prep_buildtree