| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Sami Imseih <samimseih(at)gmail(dot)com> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Andrei Lepikhov <lepihov(at)gmail(dot)com>, Greg Sabino Mullane <htamfids(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, Nikolay Samokhvalov <nik(at)postgres(dot)ai>, Ilia Evdokimov <ilya(dot)evdokimov(at)tantorlabs(dot)com> |
| Subject: | Re: track generic and custom plans in pg_stat_statements |
| Date: | 2025-07-30 07:20:28 |
| Message-ID: | aInHvKN4Gsztmopy@paquier.xyz |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Jul 29, 2025 at 05:08:09PM -0500, Sami Imseih wrote:
> The only comment I have is I think we need a NOT_SET
> member, so it can simplify the life of extensions that have code
> paths which may or may not have a PlannedStmt, such as
> pgss_store.
Okay by me for having a default that maps to something else than the
rest.
+ PLAN_STMT_NOT_SET = 0, /* origin not yet set */
The term "NOT_SET" makes me itch a little bit, even if there is an
existing parallel with OverridingKind. Perhaps your proposal is OK,
still how about "UNKNOWN" instead to use as term for the default?
> In pgss_store, I don't want to pass the entire PlannedStmt,
Neither do I.
> nor do I want to pass PLAN_STMT_INTERNAL in the call during
> post_parse_analyze, in which case we don't have a plan.
Okay.
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Hayato Kuroda (Fujitsu) | 2025-07-30 07:22:36 | RE: POC: enable logical decoding when wal_level = 'replica' without a server restart |
| Previous Message | Masahiko Sawada | 2025-07-30 06:59:45 | Re: Support getrandom() for pg_strong_random() source |