Re: Bogus bitmasking in heap2_desc

From: Julien Rouhaud <rjuju123(at)gmail(dot)com>
To: Michael Paquier <michael(at)paquier(dot)xyz>
Cc: pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: Bogus bitmasking in heap2_desc
Date: 2025-07-28 05:31:15
Message-ID: aIcLIxVpPQ2MHj2P@jrouhaud
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi,

On Mon, Jul 28, 2025 at 02:27:43PM +0900, Michael Paquier wrote:
>
> The relationship between XLOG_HEAP_OPMASK and heap2 is documented in
> heapam_xlog.h. XLOG_HEAP2_MULTI_INSERT may have XLOG_HEAP_INIT_PAGE
> set, so if we don't filter the contents from XLogRecGetInfo() then the
> record description becomes incorrect for the XLOG_HEAP2_MULTI_INSERT
> "MULTI_INSERT+INIT" case, no?
>
> Apologies if I am missing your point.

Ah I'm the one apologizing, I totally missed that comment.

Thanks for the pointing it out.

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Ashutosh Bapat 2025-07-28 06:00:08 Re: [Proposal] Expose internal MultiXact member count function for efficient monitoring
Previous Message Michael Paquier 2025-07-28 05:27:43 Re: Bogus bitmasking in heap2_desc