Bogus bitmasking in heap2_desc

From: Julien Rouhaud <rjuju123(at)gmail(dot)com>
To: pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Bogus bitmasking in heap2_desc
Date: 2025-07-27 09:19:56
Message-ID: aIXvPP62qfTbL4m0@jrouhaud
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi,

heap2_desc apparently inherited the extra bit filtering from heap_desc to
ignore XLOG_HEAP_INIT_PAGE. But XLOG_HEAP2 only has real opcodes in the
high bits there is no reason why there should be this filtering, and even if it
eventually needed additional filtering we would need something specific to this
resource manager anyway, so I think we can get rid of it as in the attached.

Attachment Content-Type Size
v1-0001-Remove-bogus-bitmask-in-heap2_desc.patch text/plain 1.1 KB

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Etsuro Fujita 2025-07-27 10:35:59 Re: [(known) BUG] DELETE/UPDATE more than one row in partitioned foreign table
Previous Message Michael Paquier 2025-07-27 08:51:35 Re: IndexAmRoutine aminsertcleanup function can be NULL?