| From: | Nathan Bossart <nathandbossart(at)gmail(dot)com> |
|---|---|
| To: | Fabrízio de Royes Mello <fabriziomello(at)gmail(dot)com> |
| Cc: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Use PqMsg_* macros in basebackup_copy.c |
| Date: | 2025-07-25 15:34:43 |
| Message-ID: | aIOkE7fgvFOu0FI_@nathan |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Fri, Jul 25, 2025 at 11:47:52AM -0300, Fabrízio de Royes Mello wrote:
> Attached patch for $SUBJECT.
Could we move this to the existing thread on the topic [0]? I see one more
CopyData character in this file, plus some others that probably need their
own characters in protocol.h:
./basebackup_copy.c:146: mysink->msgbuffer[0] = 'd'; /* archive or manifest data */
./basebackup_copy.c:173: pq_sendbyte(&buf, 'n'); /* New archive */
./basebackup_copy.c:224: pq_sendbyte(&buf, 'p'); /* Progress report */
./basebackup_copy.c:250: pq_sendbyte(&buf, 'p'); /* Progress report */
./basebackup_copy.c:265: pq_sendbyte(&buf, 'm'); /* Manifest */
[0] https://postgr.es/m/aIOW5_jI8YaBuBo0%40nathan
--
nathan
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Alexander Korotkov | 2025-07-25 15:37:35 | Re: Proposal: Limitations of palloc inside checkpointer |
| Previous Message | Paul A Jungwirth | 2025-07-25 15:34:37 | Re: PoC: adding CustomJoin, separate from CustomScan |