Re: [PATCH] Add tests for binaryheap.c

From: Nathan Bossart <nathandbossart(at)gmail(dot)com>
To: Aleksander Alekseev <aleksander(at)timescale(dot)com>
Cc: PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: [PATCH] Add tests for binaryheap.c
Date: 2025-07-16 19:34:13
Message-ID: aHf-tbrDaWJPGdTl@nathan
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Fri, Jun 27, 2025 at 02:02:22PM +0300, Aleksander Alekseev wrote:
>> I'm not sure I see much point in testing both min-heaps and max-heaps. The
>> only difference between the two is in the comparator, so IMHO the extra
>> tests really only serve to test the test comparator.
>
> Make sense. Here is the corrected patch.

I trimmed this down some more while trying to keep the coverage the same.

--
nathan

Attachment Content-Type Size
v3-0001-Add-tests-for-binaryheap.c.patch text/plain 13.3 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2025-07-16 19:36:35 Re: Fix PQport to never return NULL if the connection is valid
Previous Message Peter Geoghegan 2025-07-16 19:28:06 Re: index prefetching