| From: | Aleksander Alekseev <aleksander(at)timescale(dot)com> |
|---|---|
| To: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Cc: | Nathan Bossart <nathandbossart(at)gmail(dot)com> |
| Subject: | Re: [PATCH] Add tests for binaryheap.c |
| Date: | 2025-06-27 11:02:22 |
| Message-ID: | CAJ7c6TPOsVN9Omg5d4=V8RntDJSExtH6vDCwMbUY=S7KoAZP+g@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi Nathan,
> Adding some tests here seems like a good idea.
>
> I'm not sure I see much point in testing both min-heaps and max-heaps. The
> only difference between the two is in the comparator, so IMHO the extra
> tests really only serve to test the test comparator.
Make sense. Here is the corrected patch.
--
Best regards,
Aleksander Alekseev
| Attachment | Content-Type | Size |
|---|---|---|
| v2-0001-Add-tests-for-binaryheap.c.patch | application/octet-stream | 16.8 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Dave Cramer | 2025-06-27 11:20:38 | Re: Correct documentation for protocol version |
| Previous Message | Hayato Kuroda (Fujitsu) | 2025-06-27 10:59:09 | RE: Suggestion to add --continue-client-on-abort option to pgbench |