Fix lwlock.c and wait_event_names.txt discrepancy

From: Bertrand Drouvot <bertranddrouvot(dot)pg(at)gmail(dot)com>
To: PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Cc: Álvaro Herrera <alvherre(at)kurilemu(dot)de>
Subject: Fix lwlock.c and wait_event_names.txt discrepancy
Date: 2025-07-16 09:30:31
Message-ID: aHdxN0D0hKXzHFQG@ip-10-97-1-34.eu-west-3.compute.internal
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi hackers,

While working on [1], I noticed a discrepancy between lwlock.c and
wait_event_names.txt for 2 wait events.

Indeed, the wait event names are MultixactOffsetSLRU and MultixactMemberSLRU in
the C file but MultiXactOffsetSLRU and MultiXactMemberSLRU in the text file.

That breaks joins between pg_stat_activity and pg_wait_events on the wait
event name. PFA a patch to fix those (I'm not able to find other discrepancy
with the "automated" work I'm doing in [1], so I'm confident there is no others).

Oversight in commit 53c2a97a9266.

[1]: https://www.postgresql.org/message-id/aHZiHZ8sSQdHpyM6%40bdt-Laptop-13th-Gen-Intel-Core

Regards,

--
Bertrand Drouvot
PostgreSQL Contributors Team
RDS Open Source Databases
Amazon Web Services: https://aws.amazon.com

Attachment Content-Type Size
v1-0001-Fix-lwlock.c-and-wait_event_names.txt-discrepancy.patch text/x-diff 1.4 KB

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message shveta malik 2025-07-16 09:57:47 Re: Improve pg_sync_replication_slots() to wait for primary to advance
Previous Message Ajin Cherian 2025-07-16 09:30:17 Re: Improve pg_sync_replication_slots() to wait for primary to advance