Re: Removing unneeded self joins

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Alexander Korotkov <aekorotkov(at)gmail(dot)com>
Cc: Andrei Lepikhov <lepihov(at)gmail(dot)com>, Alena Rybakina <a(dot)rybakina(at)postgrespro(dot)ru>, Richard Guo <guofenglinux(at)gmail(dot)com>, Ranier Vilela <ranier(dot)vf(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Robert Haas <robertmhaas(at)gmail(dot)com>, Alexander Lakhin <exclusion(at)gmail(dot)com>, "Gregory Stark (as CFM)" <stark(dot)cfm(at)gmail(dot)com>, Michał Kłeczek <michal(at)kleczek(dot)org>, Dean Rasheed <dean(dot)a(dot)rasheed(at)gmail(dot)com>
Subject: Re: Removing unneeded self joins
Date: 2025-07-15 22:16:32
Message-ID: aHbTQPyMrERHNghh@paquier.xyz
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, Jul 16, 2025 at 12:38:58AM +0300, Alexander Korotkov wrote:
> I recently got notification this is in Open Items.
> https://wiki.postgresql.org/wiki/PostgreSQL_18_Open_Items
> What is your opinion on this: do we need additional hook, fair to
> leave this "as is" or another option?

I'm OK with the statu-quo on my side when it comes to plan hinting.
With the GUC workaround, it's still possible to get through so it is
not like we don't have any options. The point about other extensions
still stands, I think, but perhaps we are OK even on these fronts as
the join search hook is far from being the most popular one AFAIK.

So dropping the item and do nothing is a fine answer.
--
Michael

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Alexander Korotkov 2025-07-15 22:29:35 Re: Removing unneeded self joins
Previous Message Michael Paquier 2025-07-15 22:12:05 Re: pg_logical_slot_get_changes waits continously for a partial WAL record spanning across 2 pages